Fix/link to ereol #654
Merged
Fix/link to ereol #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fragments for manifestation with only access data - complexSearchWithPagination query
The LinkButon wraps arount the Link component, and the Link component supports this.
Eg. a user has a reservation for the Bible from the Ereol platform - upon opening the reservation details modal and clicking on the "Go to Ereolen" external link button, they will be redirected to the Bible work page on the Ereol platform. In the case of this access data not being available in the FBI API the user is redirected to the Ereol home page instead.
spaceo
requested changes
Nov 6, 2023
It was missing a wrapping div so it was misaligned.
In the reservation details test.
spaceo
requested changes
Nov 9, 2023
src/apps/reservation-list/modal/reservation-details/reservation-details-redirect.tsx
Show resolved
Hide resolved
This function compares ISBN identifiers, which can have different formats, some including spaces, and/or dashes, or without them altogether. Because of this, we remove all non-digit characters first before making a comparison.
spaceo
requested changes
Nov 15, 2023
src/apps/reservation-list/modal/reservation-details/reservation-details.tsx
Outdated
Show resolved
Hide resolved
src/apps/reservation-list/modal/reservation-details/reservation-details.tsx
Outdated
Show resolved
Hide resolved
Instead of a hard-coded static string, we now use a configurable url in the reservation details component when redirecting user to ereol's home page.
We only use the first one anyways. And limiting it to 100 could affect performance.
Adamik10
merged commit 4ed29e7
into
danskernesdigitalebibliotek:demo_2023-48-0
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-160
https://reload.atlassian.net/browse/DDFLSBP-199
Description
This PR links from the active reservation modal for ereol materials to the ereol origin page of the given material.
Eg. a user has a reservation for the Bible from the Ereol platform - upon opening the reservation details modal and clicking on the "Go to Ereolen" external link button, they will be redirected to the Bible work page on the Ereol platform.
In the case of this access data not being available in the FBI API the user is redirected to the Ereol home page instead.
Screenshot of the result
Screen.Recording.2023-11-02.at.11.43.59.mov
Additional comments or questions
n/a