Tame those translations - throw an error if a text string isn't defined with description #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The initial values need to use translation strings in order to be properly tranlslated.
Missing translations were for the order digital copy feedback message: orderDigitalCopyFeedbackBorchkUserBlockedByAgencyText orderDigitalCopyFeedbackBorchkUserNotVerifiedText orderDigitalCopyFeedbackBorchkUserNoLongerExistOnAgencyText orderDigitalCopyFeedbackErrorMunicipalityagencyidNotFoundText orderDigitalCopyFeedbackUnknownUserText
Wrapping the components in withText() does the trick. Our Cypress tests were failing because the stories didn't have access to translations.
Now that translations work in all Cypress tests we have to look for the translated text strings, not theirDefinitions
Adamik10
force-pushed
the
tame-those-translations-by-throwing-errors
branch
from
988109d to
dccc5ba
Compare
spaceo
reviewed
Dec 18, 2023
Adamik10
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFLSBP-245
Description
This PR solves a problem we are having constantly - when dpl-react and dpl-cms isn't aligned properly and translatable strings don't match between the repositories. Now whenever that happens we now throw an descriptive error saying what translation string is missing a definition.
Screenshot of the result
n/a
Additional comments or questions
n/a