Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/arrows #814

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Fix/arrows #814

merged 7 commits into from
Jan 4, 2024

Conversation

Adamik10
Copy link
Contributor

@Adamik10 Adamik10 commented Dec 29, 2023

Link to issue

https://reload.atlassian.net/browse/DDFLSBP-319

Description

This PR makes the usage of arrows on cards consistent throughout.

Screenshot of the result

n/a

Additional comments or questions

Sibling PR in the design system

@JacobArrow
Copy link
Contributor

I'm waiting for the implementation in design system before approving this :)

JacobArrow
JacobArrow previously approved these changes Jan 2, 2024
Copy link
Contributor

@JacobArrow JacobArrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some thoughts

@JacobArrow JacobArrow dismissed their stale review January 2, 2024 13:15

Wrong button

Copy link
Contributor

@JacobArrow JacobArrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some thoughts

@Adamik10 Adamik10 requested a review from JacobArrow January 3, 2024 13:18
Copy link
Contributor

@JacobArrow JacobArrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's gooooo 🚀

to 0.0.0-53111dc1d5d35ee254a8e231f1e3721088240a4a
Instead of the whole autosuggest. For some reason Cypress says it can't
see the whole thing so it's not visible apparently.
@Adamik10 Adamik10 merged commit acc8e26 into release/2024-1-0 Jan 4, 2024
15 of 16 checks passed
@Adamik10 Adamik10 deleted the fix/arrows branch January 4, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants