Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/arrows #814

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Fix/arrows #814

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
baa4580
Add arrow arrow__hover--right-small classes to stackable material
Adamik10 Dec 29, 2023
93d63a9
Add arrow-button class to arrow button elem so it behaves consistently
Adamik10 Dec 29, 2023
b63c640
Add arrow class to dashboard-notification to be implemented consistently
Adamik10 Dec 29, 2023
e2e20c8
Add arrow & arrow__hover--right-small classes to resetvation-material
Adamik10 Dec 29, 2023
27d34df
Remove usage of the non-existing "arrow" class throughout the code
Adamik10 Jan 3, 2024
790a247
Update dpl-design-system package
Adamik10 Jan 3, 2024
63b2271
Fix failinf search header text - look for visible autosuggest text items
Adamik10 Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@
"prop-types": "Since we use former ddb-react components that depend on prop-types we keep this. Should be removed when usage of prop-types is deprecated."
},
"dependencies": {
"@danskernesdigitalebibliotek/dpl-design-system": "2023.51.0-cd7e0937a067366392e60d85a9831b7d1cdf363e",
"@danskernesdigitalebibliotek/dpl-design-system": "0.0.0-53111dc1d5d35ee254a8e231f1e3721088240a4a",
"@reach/alert": "^0.17.0",
"@reach/dialog": "^0.18.0",
"@reduxjs/toolkit": "^1.9.7",
Expand Down
2 changes: 1 addition & 1 deletion src/apps/loan-list/materials/selectable-material/selectable-material.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const SelectableMaterial: FC<SelectableMaterialProps & MaterialProps> = ({
};

return (
<li className="arrow arrow__hover--right-small">
<li className="arrow__hover--right-small">
<div
className={clsx("list-materials", {
"list-materials--disabled": disabled
Expand Down
9 changes: 6 additions & 3 deletions src/apps/loan-list/materials/stackable-material/stackable-material.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,12 @@ const StackableMaterial: FC<StackableMaterialProps & MaterialProps> = ({

return (
<div
className={clsx("list-reservation my-32 cursor-pointer", {
"list-reservation--stacked": additionalMaterials > 0
})}
className={clsx(
"list-reservation my-32 cursor-pointer arrow__hover--right-small",
{
"list-reservation--stacked": additionalMaterials > 0
}
)}
role="button"
onClick={handleOpenDueDateModal}
onKeyUp={(e) => {
Expand Down
2 changes: 1 addition & 1 deletion src/apps/reservation-list/reservation-material/reservation-material.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const ReservationMaterial: FC<ReservationMaterialProps & MaterialProps> = ({
return (
<li>
<div
className="list-reservation my-32 cursor-pointer"
className="list-reservation my-32 cursor-pointer arrow__hover--right-small"
role="button"
onClick={() => openDetailsModal()}
onKeyUp={(e) => {
Expand Down
2 changes: 1 addition & 1 deletion src/apps/search-header/search-header.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ describe("Search header app", () => {
cy.getBySel("search-header-input").focus().type("ha");
cy.getBySel("autosuggest").should("not.be.visible");
cy.getBySel("search-header-input").focus().type("r");
cy.getBySel("autosuggest").should("be.visible");
cy.getBySel("autosuggest-text-item").should("be.visible");
});

it("Allows use of arrow keys to navigate autosuggest", () => {
Expand Down
1 change: 1 addition & 0 deletions src/components/Buttons/ArrowButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const ArrowButton: React.FC<ArrowButtonProps> = ({
return (
<button
aria-labelledby={arrowLabelledBy}
className="arrow-button"
JacobArrow marked this conversation as resolved.
Show resolved Hide resolved
style={pointer}
type="button"
onClick={(e) => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/card-item-list/card-list-item/card-list-item.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ const CardListItem: React.FC<CardListItemProps> = ({
<article
ref={itemRef}
data-cy={dataCy}
className="card-list-item arrow arrow__hover--right-small"
className="card-list-item arrow__hover--right-small"
onClick={() => {
handleClick();
}}
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,10 +1477,10 @@
debug "^3.1.0"
lodash.once "^4.1.1"

"@danskernesdigitalebibliotek/dpl-design-system@2023.51.0-cd7e0937a067366392e60d85a9831b7d1cdf363e":
version "2023.51.0-cd7e0937a067366392e60d85a9831b7d1cdf363e"
resolved "https://npm.pkg.github.com/download/@danskernesdigitalebibliotek/dpl-design-system/2023.51.0-cd7e0937a067366392e60d85a9831b7d1cdf363e/eaa8bd13af004074cd2447655a4bb20fccd8dc2c#eaa8bd13af004074cd2447655a4bb20fccd8dc2c"
integrity sha512-Zimpf9G00kcS7QA27wuOtN4zmrRbs+4UAADXkAq0lFE+VhaQZ7EbcueVw2tZ47UXzQUgcPbF5a9X5P1Jk/kkZQ==
"@danskernesdigitalebibliotek/dpl-design-system@0.0.0-53111dc1d5d35ee254a8e231f1e3721088240a4a":
version "0.0.0-53111dc1d5d35ee254a8e231f1e3721088240a4a"
resolved "https://npm.pkg.github.com/download/@danskernesdigitalebibliotek/dpl-design-system/0.0.0-53111dc1d5d35ee254a8e231f1e3721088240a4a/b7efe97875a0bae09fc27425250b8de333dd0476#b7efe97875a0bae09fc27425250b8de333dd0476"
integrity sha512-U1orycYBJoaLt42wVXTc0+XNpuatby/JD2gV1YH8ewd0lOo6yNhik2U/iSbcKIsUpwrGx64itxEPt9e+dbRXNw==

"@discoveryjs/json-ext@^0.5.0", "@discoveryjs/json-ext@^0.5.3":
version "0.5.7"
Expand Down
Loading