Change the 'Reserve' button text to the standard and move the notice about material ordered from other libraries to the MaterialAvailabilityTextParagraph.
#854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperbirch1
force-pushed
the
fix-overbygningsmateriale-2024
branch
7 times, most recently
from
9deea60 to
90c5d21
Compare
spaceo
requested changes
Jan 16, 2024
There was a problem hiding this comment.
I don't understand what the fix you did what it consists of it what it solves.
I wrote some comments that are related to code style/practise.
Also I think that the ReservationModalBody has too much logic inside of the comopnent. It would be nice to på the saveReservation handler and state in an external hook
kasperbirch1
force-pushed
the
fix-overbygningsmateriale-2024
branch
from
90c5d21 to
2fab8ad
Compare
kasperbirch1
force-pushed
the
fix-overbygningsmateriale-2024
branch
from
2fab8ad to
40f5360
Compare
|
This has been lingering for quite a while now. I am assigning this to you @kasperbirch1 so you can figure out what is needed to move this along. |
kasperbirch1
force-pushed
the
fix-overbygningsmateriale-2024
branch
2 times, most recently
from
016bf5b to
acff10d
Compare
…about material ordered from other libraries to the `MaterialAvailabilityTextParagraph`. This will give the user a more streamlined experience while still notifying the user that the material is ordered from another library.
kasperbirch1
force-pushed
the
fix-overbygningsmateriale-2024
branch
from
acff10d to
5d38f24
Compare
|
@spaceo now it finally works 👍 |
…therLibrary` For better code readability
kasperbirch1
force-pushed
the
fix-overbygningsmateriale-2024
branch
from
0e73838 to
5658543
Compare
spaceo
reviewed
Apr 15, 2024
...components/material/material-buttons/physical/MaterialButtonReservableFromAnotherLibrary.tsx
Outdated
Show resolved
Hide resolved
kasperbirch1
force-pushed
the
fix-overbygningsmateriale-2024
branch
from
161cf51 to
66d9353
Compare
kasperbirch1
force-pushed
the
fix-overbygningsmateriale-2024
branch
from
66d9353 to
f854c63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue
https://reload.atlassian.net/browse/DDFSOEG-528
Description
This PR enhances the user experience by providing a more streamlined interface, while still effectively notifying the user when the material is ordered from an another library.
In this revision, I have incorporated a useEffect hook within the
UserListItemscomponent. This modification ensures that the default branch and interest period, as specified in theModalReservationFormSelect, are consistently used as the values transmitted with the request.Screenshot of the result
Skaermoptagelse.2024-04-03.kl.13.59.37.mov