Fix unions schema to match JSON. #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Aug 7, 2024
schemas/macro_service.schema.json
Outdated
Comment on lines
42
to
44
| "properties": {"type": {"type": "string"}, "value": {"oneOf": [ | ||
| {"$ref": "#/$defs/AugmentRequest"} | ||
| ]}} |
There was a problem hiding this comment.
nit: can we format these so they are easier to understand, for objects with a single key/value or lists with a single entry I am OK with collapsing them on one line, but when it gets nested it gets pretty confusing
Suggested change
| "properties": {"type": {"type": "string"}, "value": {"oneOf": [ | |
| {"$ref": "#/$defs/AugmentRequest"} | |
| ]}} | |
| "properties": { | |
| "type": {"type": "string"}, | |
| "value": { | |
| "oneOf": [ | |
| {"$ref": "#/$defs/AugmentRequest"} | |
| ] | |
| } | |
| } |
There was a problem hiding this comment.
Yeeeah I was in two minds about this, it's awkward to collapse but it's also awkward expanded as it's boilerplate :)
Formatted the whole file with the VSCode formatter, which is probably what we end up doing/enforcing anyway. Thanks.
jakemac53
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With a note that we should actually do #8 so that this kind of mistake is caught automatically :)