Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a python http_request wrapper to create external tools #28

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

sunishsheth2009
Copy link
Contributor

Adding a python http_request wrapper to create external tools

@sunishsheth2009 sunishsheth2009 force-pushed the sunish-external-tools-http branch 3 times, most recently from b5e0119 to 947dc7d Compare December 11, 2024 19:11
Copy link
Collaborator

@smurching smurching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments but mostly looks great, thanks @sunishsheth2009 !

@sunishsheth2009 sunishsheth2009 force-pushed the sunish-external-tools-http branch from 7d213c5 to 4d27cb7 Compare December 16, 2024 18:23
Signed-off-by: Sunish Sheth <[email protected]>
@sunishsheth2009 sunishsheth2009 force-pushed the sunish-external-tools-http branch from 4d27cb7 to d861da6 Compare December 16, 2024 18:25
Copy link
Collaborator

@smurching smurching left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sunishsheth2009 sunishsheth2009 merged commit efb256a into main Dec 16, 2024
5 checks passed
@sunishsheth2009 sunishsheth2009 deleted the sunish-external-tools-http branch December 16, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants