New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: BI-5951 presigned url generation in file-uploader-api #756

Merged

KonstantAnxiety merged 3 commits into main from konstasa/presigned-url-1

Dec 20, 2024

Contributor

KonstantAnxiety commented Dec 19, 2024 •

edited

Loading

Also includes:

decrease DataFile Redis TTL from 12h to 3h
rename all DataFile instances across the codebase to "dfile"
transition from DataFile s3_key generated from its id to s3_key stored in Redis

github-actions bot added the type/feat label

KonstantAnxiety changed the title ~~feat: BI-5951 WIP presigned url generation in file-uploader-api~~ feat: BI-5951 presigned url generation in file-uploader-api

KonstantAnxiety added 3 commits

December 20, 2024 16:26


          feat: BI-5951 WIP presigned url generation in file-uploader-api

6f145a4


          fix handler, fix mypy

2bfc2d0


          update comments

5760e82

KonstantAnxiety force-pushed the konstasa/presigned-url-1 branch from 411bfa5 to 5760e82 Compare

December 20, 2024 13:26

KonstantAnxiety marked this pull request as ready for review

December 20, 2024 14:07

ovsds reviewed

View reviewed changes

lib/dl_file_uploader_api_lib/dl_file_uploader_api_lib/views/files.py Show resolved Hide resolved

ovsds reviewed

View reviewed changes

lib/dl_file_uploader_api_lib/dl_file_uploader_api_lib/views/files.py Show resolved Hide resolved

ovsds reviewed

View reviewed changes

lib/dl_file_uploader_api_lib/dl_file_uploader_api_lib/views/files.py Show resolved Hide resolved

ovsds reviewed

View reviewed changes

lib/dl_file_uploader_lib/dl_file_uploader_lib/redis_model/models/models.py Show resolved Hide resolved

ovsds reviewed

View reviewed changes

lib/dl_file_uploader_lib/dl_file_uploader_lib/redis_model/models/models.py Show resolved Hide resolved

ovsds reviewed

View reviewed changes

lib/dl_s3/dl_s3/s3_service.py Show resolved Hide resolved

ovsds approved these changes

View reviewed changes

Contributor Author

KonstantAnxiety commented Dec 20, 2024

Going to include fixes for comments in the 2nd part of this PR, since I've already pushed a part of it #762

KonstantAnxiety merged commit 413bacc into main

29 checks passed

KonstantAnxiety deleted the konstasa/presigned-url-1 branch

December 20, 2024 15:41

KonstantAnxiety mentioned this pull request

feat: BI-5952 WIP file-uploader-api handler for processing presigned file from bucket #762

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels