feat: BI-5952 file-uploader-api handler for processing presigned file from bucket #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KonstantAnxiety
force-pushed
the
konstasa/presigned-url-2
branch
from
61679ab to
c195125
Compare
KonstantAnxiety
commented
Dec 20, 2024
KonstantAnxiety
changed the title
ovsds
reviewed
Dec 25, 2024
ovsds
previously approved these changes
Dec 25, 2024
ovsds
approved these changes
Dec 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had to switch to minio for s3 because cloudserver does not implement POST upload with presigned url
Also foreshadowing issues with presigned URLs, as far as I've tested, presigned URL region does not matter, but this could be just for YC where there is only one region, so I think we should add region name to our S3 settings in future