-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dbt-core dependency of dbt-common for testing #105
Conversation
From the test I ran:
These are how they map: sha of my branch: We want to use the merge sha so the following should work:
We are currently using |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
=======================================
Coverage 56.26% 56.26%
=======================================
Files 50 50
Lines 3082 3082
=======================================
Hits 1734 1734
Misses 1348 1348
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…dbt-labs/dbt-common into er/fix-core-merge-queue-testing
resolves #104
Related to initial fix in #68
Description
When we run dbt-core tests we're not using the right sha when we're merging in so a change that breaks core doesn't block the merge.
This leverages a new script from #105 to update the dev-requirements so that tox installs the correct sha.
Checklist
changie new
to create a changelog entry