Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dbt-core dependency of dbt-common for testing #105

Merged
merged 8 commits into from
Apr 24, 2024
Merged

Update dbt-core dependency of dbt-common for testing #105

Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d8a182
debugging all the values
emmyoop Apr 12, 2024
274c63b
Merge branch 'main' into er/fix-core-merge-queue-testing
emmyoop Apr 12, 2024
322429a
update dependency before running tox
emmyoop Apr 24, 2024
e5ff1e4
fix path, pass in repo
emmyoop Apr 24, 2024
2664cf0
put back final ref output
emmyoop Apr 24, 2024
6b6bb8e
Merge branch 'main' into er/fix-core-merge-queue-testing
MichelleArk Apr 24, 2024
4f9c9f7
install tox
emmyoop Apr 24, 2024
5db1b2d
Merge branch 'er/fix-core-merge-queue-testing' of https://github.com/…
emmyoop Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 4 additions & 24 deletions .github/workflows/ci_dbt_core_testing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,19 +132,9 @@ jobs:
python -m pip install --upgrade pip
python -m pip --version

# tox takes care of installing the correct version of dbt-core dependencies but we need to
# install them first s that we can override the dbt-common branch
- name: "Manually install dbt-core dependencies"
- name: "Update dbt-common dependency to ${{ needs.job-prep.outputs.dbt-common-ref }}"
run: |
python -m pip uninstall dbt-common -y
python -m pip install -r dev-requirements.txt -r editable-requirements.txt

# Since the dbt-common dependency is pinned in dev-requirements.txt we need to force update it
# Since tox installs dependencies but doesn't force update, it won't get overridden in the next
# step since the requirements will already be met
- name: "Force update the version of dbt-common@${{ needs.job-prep.outputs.dbt-common-ref }}"
run: |
python -m pip install pip install git+https://github.com/dbt-labs/dbt-common.git@${{ needs.job-prep.outputs.dbt-common-ref }} --force-reinstall
./scripts/update_dev_packages.sh ${{ github.repository.name}} ${{ needs.job-prep.outputs.dbt-common-ref }}

- name: "Run unit tests"
# Doing the check here instead of the top level because this is job a required check, the
Expand Down Expand Up @@ -242,19 +232,9 @@ jobs:
python -m pip install --upgrade pip
python -m pip --version

# tox takes care of installing the correct version of dbt-core dependencies but we need to
# install them first s that we can override the dbt-common branch
- name: "Manually install dbt-core dependencies"
run: |
python -m pip install -r dev-requirements.txt -r editable-requirements.txt

# Since the dbt-common dependency is pinned in dev-requirements.txt we need to force update it
# Since tox installs dependencies but doesn't force update, it won't get overridden in the next
# step since the requirements will already be met
- name: "Force update the version of dbt-common@${{ needs.job-prep.outputs.dbt-common-ref }}"
- name: "Update dbt-common dependency to ${{ needs.job-prep.outputs.dbt-common-ref }}"
run: |
python -m pip uninstall dbt-common -y
python -m pip install pip install git+https://github.com/dbt-labs/dbt-common.git@${{ needs.job-prep.outputs.dbt-common-ref }} --force-reinstall
./scripts/update_dev_packages.sh ${{ github.repository.name}} ${{ needs.job-prep.outputs.dbt-common-ref }}

- name: "Run Functional tests"
run: tox -- --ddtrace
Expand Down
Loading