feat: Single Sign On #1963
Merged
feat: Single Sign On #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Fernando Zavalia <[email protected]>
fzavalia
commented
Aug 8, 2023
| @@ -6,6 +6,7 @@ module.exports = override( | |||
| path.resolve(__dirname, 'src'), | |||
| path.resolve(__dirname, 'node_modules/react-virtualized-auto-sizer'), | |||
| path.resolve(__dirname, 'node_modules/decentraland-connect/node_modules/@walletconnect'), | |||
| path.resolve(__dirname, 'node_modules/@walletconnect') | |||
| path.resolve(__dirname, 'node_modules/@walletconnect'), | |||
| path.resolve(__dirname, 'node_modules/@dcl/single-sign-on-client'), | |||
There was a problem hiding this comment.
Package has some unsupported operators by the bundler version used here like ??. So it has to be added in the overrides.
fzavalia
commented
Aug 8, 2023
| "homepage": "", | ||
| "jest": { | ||
| "moduleNameMapper": { | ||
| "@dcl/single-sign-on-client": "identity-obj-proxy" |
There was a problem hiding this comment.
As the module is an ESM and not CommonJs, jest doesn't like it. Doing this will replace it in tests with a mockable stub.
fzavalia
commented
Aug 8, 2023
| @@ -49,13 +48,11 @@ export function initStore() { | |||
| paths: [ | |||
| ['ui', 'archivedBidIds'], | |||
| ['ui', 'preview', 'isTryingOn'], | |||
| ['identity', 'data'] | |||
There was a problem hiding this comment.
By removing this, the identity is not persisted in local storage anymore. It is now persisted in the iframe so there is no reason for it.
cyaiox
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.