fix: Fix widget plugin python warnings #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Aug 20, 2024
| @@ -13,6 +13,35 @@ | |||
| __all__ = ["is_enterprise_environment", "create_js_plugin"] | |||
|
|
|||
|
|
|||
| class CommonJsPlugin(JsPlugin): | |||
There was a problem hiding this comment.
What's the point of having all the individual plugin classes (UiJsPlugin, ExpressJsPlugin, MatplotlibJsPlugin)? They all do the exact same thing.
We should just get rid of the plugin_class parameter entirely (deprecate first, release, then remove), and then it can just create a CommonJsPlugin in there.
Or is there another reason to be able to specify a custom class?
There was a problem hiding this comment.
No reason that I know of.
I've got #741 up to remove them from the plugins
mofojed
requested changes
Aug 30, 2024
mofojed
previously approved these changes
Sep 4, 2024
mofojed
approved these changes
Sep 5, 2024
mofojed
added a commit
that referenced
this pull request
Sep 19, 2024
Followup for #740 Modifies our plugins to use `CommonJsPlugin` by dropping the arg (since it's made optional in #740) and using the default. --------- Co-authored-by: mikebender <[email protected]>
wusteven815
pushed a commit
to wusteven815/deephaven-plugins
that referenced
this pull request
Sep 24, 2024
Followup for deephaven#740 Modifies our plugins to use `CommonJsPlugin` by dropping the arg (since it's made optional in deephaven#740) and using the default. --------- Co-authored-by: mikebender <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #713
Mostly minor warnings fixed
The main fix of consequence is a new class,
CommonJsPlugin, in utilities. This should be inherited from by all plugins that useJsPluginbecausecreate_js_pluginactually requires something of the formCommonJsPluginasJsPlugindoesn't specify the inputs it takes. I madeCommonJsPluginthe default but aJsPlugincan still be passed so that this doesn't break existing plugins. We should do this first and release a newutilitiespackage. I will make a follow-up PR that will fix the inheritance on all our packages to ensure the typing is correct.