fix: Correct type for generated JsPlugin #741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mofojed
requested changes
Aug 27, 2024
|
We will need a |
mofojed
previously approved these changes
Sep 19, 2024
- In the future, we should probably use local version identifiers instead of the .devN tags: https://packaging.python.org/en/latest/specifications/version-specifiers/#local-version-identifiers
mofojed
approved these changes
Sep 19, 2024
wusteven815
pushed a commit
to wusteven815/deephaven-plugins
that referenced
this pull request
Sep 24, 2024
Followup for deephaven#740 Modifies our plugins to use `CommonJsPlugin` by dropping the arg (since it's made optional in deephaven#740) and using the default. --------- Co-authored-by: mikebender <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup for #740
Won't pass everything yet.
Modifies our plugins to use
CommonJsPluginby dropping the arg (since it's made optional in #740) and using the default.