Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add Margaret as a reviewer automatically to any docs changes #778

Merged
merged 9 commits into from
Aug 29, 2024

Conversation

mattrunyon
Copy link
Collaborator

@mattrunyon mattrunyon commented Aug 28, 2024

This will request @margaretkennedy as a reviewer any time a docs markdown file is changed without making her a codeowner and a required review.

It will not re-request review from her, so it will allow PR authors to make multiple commits and then re-request once they're ready

Example of the action working: mattrunyon-test-org/test-public#37

@mattrunyon mattrunyon self-assigned this Aug 28, 2024
Copy link
Member

@mofojed mofojed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonder if we could/should leverage using Teams in GitHub for assigning, instead of just assigning Margaret: https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team

@mattrunyon
Copy link
Collaborator Author

We could. I just did this as the easiest first iteration since it was only requested that Margaret be added.

I think the only modification would be checking teams instead of users in requested reviews and probably some other check in the submitted reviews.

I added logic to not re-request review if there's already a requested review or existing review. Once reviewed, Github does not list under requested reviews, so requestReviewers is equivalent to clicking the "re-request review" button. I didn't want that to be automatic so PR authors can re-request when they're ready

@mattrunyon mattrunyon changed the title Test adding reviewers ci: Add Margaret as a reviewer automatically to any docs changes Aug 28, 2024
@mattrunyon mattrunyon merged commit 5a9de22 into deephaven:main Aug 29, 2024
12 of 13 checks passed
@mattrunyon mattrunyon deleted the margaret-docs-reviewer branch August 29, 2024 20:08
@dsmmcken dsmmcken mentioned this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants