-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Add Margaret as a reviewer automatically to any docs changes #778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we could/should leverage using Teams in GitHub for assigning, instead of just assigning Margaret: https://docs.github.com/en/organizations/organizing-members-into-teams/managing-code-review-settings-for-your-team
We could. I just did this as the easiest first iteration since it was only requested that Margaret be added. I think the only modification would be checking I added logic to not re-request review if there's already a requested review or existing review. Once reviewed, Github does not list under requested reviews, so |
This will request @margaretkennedy as a reviewer any time a docs markdown file is changed without making her a codeowner and a required review.
It will not re-request review from her, so it will allow PR authors to make multiple commits and then re-request once they're ready
Example of the action working: mattrunyon-test-org/test-public#37