-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sources): add hf data source #106
feat(sources): add hf data source #106
Conversation
Trivy scanning results. .venv/lib/python3.10/site-packages/PyJWT-2.9.0.dist-info/METADATA (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: JWT (jwt-token) .venv/lib/python3.10/site-packages/litellm/llms/huggingface_llms_metadata/hf_text_generation_models.txt (secrets)Total: 1 (MEDIUM: 0, HIGH: 0, CRITICAL: 1) CRITICAL: HuggingFace (hugging-face-access-token) .venv/lib/python3.10/site-packages/litellm/proxy/_types.py (secrets)Total: 1 (MEDIUM: 1, HIGH: 0, CRITICAL: 0) MEDIUM: Slack (slack-web-hook) |
Code Coverage Summary
Diff against main
Results for commit: 9f7704e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
@@ -86,6 +89,7 @@ def get_id(self) -> str: | |||
""" | |||
return f"gcs:gs://{self.bucket}/{self.object_name}" | |||
|
|||
@requires_dependencies(["gcloud.aio.storage"], "gcs") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm testing a new way of handling optional dependencies. Since managing error messages from extra deps is starting to get tedious, I decided to wrap them in @requires_dependencies
decorator that handles them automatically.
If you like it, we can add a new issue to refactor the handling of optional deps, there're several other places where this decorator should be applied.
packages/ragbits-document-search/src/ragbits/document_search/documents/sources.py
Outdated
Show resolved
Hide resolved
packages/ragbits-document-search/src/ragbits/document_search/documents/sources.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.