Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pgvector Document Store - minimal implementation #239

Merged
merged 22 commits into from
Jan 23, 2024
Merged

Pgvector Document Store - minimal implementation #239

merged 22 commits into from
Jan 23, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Jan 18, 2024 •
edited
Loading

Part of #142

Minimal implementation of the Document Store logic using psycopg3.

Missing parts (to be added in future PRs):

  • filters
  • embedding retrieval

@anakin87 anakin87 mentioned this pull request Jan 19, 2024
Closed
@anakin87 anakin87 changed the title Pgvector draft Pgvector Document Store - minimal implementation Jan 21, 2024
@anakin87 anakin87 requested a review from masci January 21, 2024 17:18
@anakin87 anakin87 marked this pull request as ready for review January 21, 2024 17:18
@anakin87 anakin87 requested a review from a team as a code owner January 21, 2024 17:18
@anakin87 anakin87 requested review from ZanSara and removed request for a team January 21, 2024 17:18
@anakin87 anakin87 removed the request for review from ZanSara January 21, 2024 17:19
masci
masci suggested changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a first pass

integrations/pgvector/src/haystack_integrations/document_stores/pgvector/document_store.py Outdated Show resolved Hide resolved
integrations/pgvector/src/haystack_integrations/document_stores/pgvector/document_store.py Outdated Show resolved Hide resolved
integrations/pgvector/src/haystack_integrations/document_stores/pgvector/document_store.py Outdated Show resolved Hide resolved
integrations/pgvector/src/haystack_integrations/document_stores/pgvector/document_store.py Outdated Show resolved Hide resolved
integrations/pgvector/src/haystack_integrations/document_stores/pgvector/document_store.py Outdated Show resolved Hide resolved
@anakin87 anakin87 requested a review from masci January 23, 2024 11:05
masci
masci approved these changes Jan 23, 2024
View reviewed changes
Copy link
Contributor

@masci masci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! :shipit:

@anakin87 anakin87 merged commit 077a6aa into main Jan 23, 2024
6 checks passed
@anakin87 anakin87 deleted the pgvector-draft branch January 23, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masci masci masci approved these changes

Assignees
No one assigned
Labels
topic:CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anakin87 @masci