-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Cohere inconsistent embeddings and documents lengths #284
Conversation
Hey @ZanSara I'm noticing that the integration tests that require a Cohere API key are not running in CI. Is this on purpose or should we be able to run them? |
Hey @sjrl, thank you for this PR! Let's split the two things though:
Thank you for your help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing out the example code the improvement is evident! Thank you for fixing this one! 🤗
Thanks for this fix. When will the release be cut for https://pypi.org/project/cohere-haystack/? |
I am looking into this issue #283 and found a bug that I think is unrelated.
Update:
Running the code in issue #283 shows that the changes in this branch do seem to help. See comment here.
Basically we were copying the embeddings so we'd end up with twice as many embeddings as documents. I don't think this will fix the error brought up in issue #283, but we should avoid doing this.
Additional: