Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cohere inconsistent embeddings and documents lengths #284

Merged
merged 9 commits into from
Feb 6, 2024
Merged

fix: Cohere inconsistent embeddings and documents lengths #284

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a84bc95
Don't double length of embeddings vs documents
sjrl Jan 29, 2024
5417a6f
Fix issue
sjrl Jan 29, 2024
b0c17f7
Fix failing tests
sjrl Jan 29, 2024
96ad186
Fix pylint
sjrl Jan 29, 2024
a962b94
Pylint
sjrl Jan 29, 2024
00d3f9f
Undo test fixes
sjrl Feb 5, 2024
c3257a9
Fix linter
sjrl Feb 5, 2024
a4fac35
Merge branch 'main' into cohere-fix
sjrl Feb 5, 2024
3ddff45
Merge branch 'main' into cohere-fix
sjrl Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions integrations/cohere/src/haystack_integrations/components/embedders/cohere/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,6 @@ def get_response(
response = cohere_client.embed(batch, model=model_name, input_type=input_type, truncate=truncate)
for emb in response.embeddings:
all_embeddings.append(emb)
embeddings = [list(map(float, emb)) for emb in response.embeddings]
all_embeddings.extend(embeddings)
if response.meta is not None:
metadata = response.meta

Expand Down