Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WeaviateEmbeddingRetriever #412

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add WeaviateEmbeddingRetriever #412

merged 1 commit into from
Feb 14, 2024

Conversation

silvanocerza
Copy link
Contributor

Part of #131. Depends on #410.

@silvanocerza silvanocerza self-assigned this Feb 14, 2024
@silvanocerza silvanocerza requested a review from a team as a code owner February 14, 2024 11:38
@silvanocerza silvanocerza requested review from anakin87 and removed request for a team February 14, 2024 11:38
@github-actions github-actions bot added integration:weaviate type:documentation Improvements or additions to documentation labels Feb 14, 2024
Copy link
Member

@anakin87 anakin87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Unrelated to this PR:
as a user, I would like to understand how I can set a different distance metric when I create my Document Store/Index.
Can we expose this configuration and make it visible?

Base automatically changed from weaviate-bm25 to main February 14, 2024 13:48
@silvanocerza silvanocerza merged commit be40dcb into main Feb 14, 2024
9 checks passed
@silvanocerza silvanocerza deleted the weaviate-embedding branch February 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration:weaviate type:documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants