-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify nightly failures #577
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
integration:instructor-embedders
integration:chroma
integration:elasticsearch
integration:opensearch
integration:unstructured-fileconverter
integration:gradient
integration:cohere
integration:jina
integration:google-vertex
integration:qdrant
integration:pinecone
integration:google-ai
integration:ollama
integration:llama_cpp
labels
Mar 13, 2024
anakin87
requested review from
silvanocerza
and removed request for
a team and
silvanocerza
March 13, 2024 12:09
masci
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
integration:astra
integration:chroma
integration:cohere
integration:deepeval
integration:elasticsearch
integration:fastembed
integration:google-ai
integration:google-vertex
integration:gradient
integration:instructor-embedders
integration:jina
integration:llama_cpp
integration:mistral
integration:mongodb-atlas
integration:nvidia
integration:ollama
integration:opensearch
integration:optimum
integration:pgvector
integration:pinecone
integration:qdrant
integration:ragas
integration:unstructured-fileconverter
integration:uptrain
integration:weaviate
topic:CI
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #486
Based on #574. Do not merge before the base has been merged.
As discussed, I added a notification step to each integration workflow:
if the test is a nightly run (== is scheduled) and fails, a corresponding event is sent to Datadog, which then takes care of notifications using a specifically configured Monitor.
To reduce duplication, I created a composite action to send events to Datadog.
As you may have noticed, I ran several manual tests.