Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Document Stores initially skip SparseEmbedding #606

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Make Document Stores initially skip SparseEmbedding #606

merged 1 commit into from
Mar 20, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Mar 20, 2024 •
edited
Loading

Fixes #604: see that for details

@anakin87 anakin87 changed the title Make Document Stores initially skip SparseEmbedding Make Document Stores initially skip SparseEmbedding Mar 20, 2024
@anakin87 anakin87 marked this pull request as ready for review March 20, 2024 13:59
@anakin87 anakin87 requested a review from a team as a code owner March 20, 2024 14:00
@anakin87 anakin87 requested review from davidsbatista and removed request for a team March 20, 2024 14:00
davidsbatista
davidsbatista approved these changes Mar 20, 2024
View reviewed changes
Copy link
Contributor

@davidsbatista davidsbatista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anakin87 anakin87 merged commit b4ff369 into main Mar 20, 2024
48 checks passed
@anakin87 anakin87 deleted the prepare-document-stores-for-sparse branch March 20, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbatista davidsbatista davidsbatista approved these changes

Assignees
No one assigned
Labels
integration:astra integration:chroma integration:elasticsearch integration:mongodb-atlas integration:pgvector integration:pinecone integration:qdrant integration:weaviate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Document Stores initially skip SparseEmbedding
2 participants
@anakin87 @davidsbatista