Deserialize secrets inplace for api_keys in PineconeEmbeddingRetriever #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading serialised pipeline which includes PineconeEmbeddingRetriever with PineconeDocumentStore currently fails because loading of api keys is not correctly deserialised into Secret class. I propose changes to fix this.
|
|
|
Please solve this bug ASAP as it's preventing me from using serialised haystack pipelines in deployment. |
|
Thanks for the bug report and the PR! Since the correct fix for it was a bit more involved, we've opened another one. I'll close this in favour of the latter. |
|
Released a new version: https://pypi.org/project/pinecone_haystack/0.4.1/ |
|
Cheers, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading serialised pipeline which includes PineconeEmbeddingRetriever with PineconeDocumentStore currently fails because loading of api keys is not correctly deserialised into Secret class. I propose changes to fix this.