Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deserialize secrets inplace for api_keys in PineconeEmbeddingRetriever #634

Closed
wants to merge 1 commit into from
+2 −1
Closed

Deserialize secrets inplace for api_keys in PineconeEmbeddingRetriever #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .../pinecone/src/haystack_integrations/components/retrievers/pinecone/embedding_retriever.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
from haystack.dataclasses import Document

from haystack_integrations.document_stores.pinecone import PineconeDocumentStore

from haystack.utils import deserialize_secrets_inplace

@component
class PineconeEmbeddingRetriever:
Expand Down Expand Up @@ -93,6 +93,7 @@ def from_dict(cls, data: Dict[str, Any]) -> "PineconeEmbeddingRetriever":
:returns:
Deserialized component.
"""
deserialize_secrets_inplace(data["init_parameters"]['document_store']['init_parameters'], keys=["api_key"])
data["init_parameters"]["document_store"] = default_from_dict(
PineconeDocumentStore, data["init_parameters"]["document_store"]
)
Expand Down
Loading