Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pgvector #162

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Add pgvector #162

merged 2 commits into from
Feb 8, 2024

Conversation

anakin87
Copy link
Member

@anakin87 anakin87 commented Feb 5, 2024

Copy link

@annthurium annthurium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job!

I ran the code examples, validated that they produce the expected output.

A few nits, otherwise this is good to merge.

integrations/pgvector-documentstore.md Show resolved Hide resolved
integrations/pgvector-documentstore.md Show resolved Hide resolved
repo: https://github.com/deepset-ai/haystack-core-integrations/tree/main/integrations/pgvector
type: Document Store
report_issue: https://github.com/deepset-ai/haystack-core-integrations/issues
version: Haystack 2.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the logo is missing?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pgvector does not have a logo. Maybe because it is an extension of PostgreSQL.
We could also insert the logo of PostgreSQL, but it would be a bit misleading

@anakin87
Copy link
Member Author

anakin87 commented Feb 8, 2024

Thanks @annthurium!

@anakin87 anakin87 merged commit 9c1e629 into deepset-ai:main Feb 8, 2024
@anakin87 anakin87 deleted the pgvector branch February 8, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants