You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@mathislucka I have started working on this, can you clarify something for me?
When it comes to metadata filtering there is way suggested in the template, but the one followed in chroma docstore is quite different, how should I proceed from here?
There is one more thing that I wanted to ask,
Context: We have different methods in different document stores, they have 4 in common [count_document, filter_document, write_document, delete_document] and there are some just to support them , but apart from them there are some extras.
Question: Do we have to implement those lacking functions in all the document store? If you could give me a list of all the function that will be required based on our current requirements.
the official metadata filtering is that of the template. You can find more information in the docs.
I think filters in Chroma Document Store are the legacy filters.
as explained in Creating Custom Document Stores, each Document Store must respect the Document Store protocol, by implementing the 4 standard methods (respecting their signature). For functions that are specific to your Document Store, you are free to implement any other methods you need.
incremental development: I suggest you create one of the 4 standard methods at a time and test it. DocumentStoreBaseTests was recently refactored to allow this.
An example
you implement count_documents
in test_document_store.py, you define the test class TestDocumentStore(CountDocumentsTest): please note that here we are only inheriting from CountDocumentsTest
you make tests pass
you implement write_documents
in test_document_store.py, you define the testing class TestDocumentStore(CountDocumentsTest, WriteDocumentsTest): here we are also inheriting from WriteDocumentsTest
Summary and motivation
PGVector is a popular request from our community. We should have it in 2.0.
Detailed design
TBD
Checklist
If the request is accepted, ensure the following checklist is complete before closing this issue.
main
branchintegration:<your integration name>
has been added to this repoThe text was updated successfully, but these errors were encountered: