Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused query parameter from MetaFieldRanker 2.0 #6292

Closed
julian-risch opened this issue Nov 13, 2023 · 1 comment · Fixed by #6300
Closed

Remove unused query parameter from MetaFieldRanker 2.0 #6292

julian-risch opened this issue Nov 13, 2023 · 1 comment · Fixed by #6300
Labels
2.x Related to Haystack v2.0

Comments

@julian-risch
Copy link
Member

#6189 introduced the new MetaFieldRanker. The run method takes a mandatory query parameter as input, which is not used at all. Therefore, let's remove this parameter.
@julian-risch julian-risch added the 2.x Related to Haystack v2.0 label Nov 13, 2023
@julian-risch julian-risch mentioned this issue Nov 13, 2023
Closed
@anakin87 anakin87 mentioned this issue Nov 13, 2023
Closed
@awinml awinml mentioned this issue Nov 14, 2023
Merged
@awinml
Copy link
Contributor

awinml commented Nov 14, 2023

@julian-risch I would like to work on this issue, I have opened a PR (#6300) that fixes this issue.

@sahusiddharth sahusiddharth mentioned this issue Nov 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2.x Related to Haystack v2.0
Projects
None yet
Milestone
No milestone
2 participants
@julian-risch @awinml