feat!: Remove unused query parameter from MetaFieldRanker
#6300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic:tests
2.x
julian-risch
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
@awinml Great pull request! 👍 I have no change requests. Thank you for adding the release note. I will just change the PR title to make more visible that this is actually a breaking change. Users who are using ranker.run(query="", documents=docs)will need to update their code after this PR, which was expected.
julian-risch
changed the title
MetaFieldRankerMetaFieldRanker
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
MetaFieldRanker2.0 #6292Proposed Changes:
Removes the
queryparameter from the run method ofMetaFieldRanker.How did you test it?
Updated existing Unit and Integration tests.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.