-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: HuggingFaceAPITextEmbedder
#7484
Conversation
haystack/utils/url_validation.py
Outdated
from urllib.parse import urlparse | ||
|
||
|
||
def is_valid_http_url(url) -> bool: | ||
r = urlparse(url) | ||
return all([r.scheme in ["http", "https"], r.netloc]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be ignored.
I introduced and tested it in #7464, but I also added it in this PR to make the 2 PRs independent.
Pull Request Test Coverage Report for Build 8597162116Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Related Issues
Proposed Changes:
HuggingFaceAPITextEmbedder
HuggingFaceTEITextEmbedder
How did you test it?
CI, new tests, extensive manual tests: with HF Inference API, local TEI container and paid HF Inference Endpoint
Checklist
fix:
,feat:
,build:
,chore:
,ci:
,docs:
,style:
,refactor:
,perf:
,test:
.