Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate legacy document/metadata filters #8004

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

shadeMe
Copy link
Contributor

@shadeMe shadeMe commented Jul 9, 2024

@shadeMe shadeMe requested review from a team as code owners July 9, 2024 13:58
@shadeMe shadeMe requested review from dfokina and silvanocerza and removed request for a team July 9, 2024 13:58
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9858455138

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 90.037%

Files with Coverage Reduction New Missed Lines %
utils/filters.py 2 98.65%
Totals Coverage Status
Change from base Build 9858006084: 0.002%
Covered Lines: 6787
Relevant Lines: 7538

💛 - Coveralls

@shadeMe shadeMe merged commit f19131f into deepset-ai:main Jul 9, 2024
18 checks passed
@shadeMe shadeMe deleted the chore/deprecate-legacy-filters branch July 9, 2024 14:19
@vblagoje
Copy link
Member

vblagoje commented Jul 10, 2024

@silvanocerza @shadeMe I'm including this one in 2.3.0-rc2 and final. Is that ok?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate use of legacy filters syntax in Astra Document Store integration
4 participants