New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: access control #74

Merged

gas1cent merged 52 commits into dev from feat/access-control

Nov 12, 2024

Contributor

xorsal commented Oct 23, 2024 •

edited

Loading

🤖 Linear

Closes OPT-512

xorsal added 5 commits

October 23, 2024 15:54


          feat: use access control in all the necessary functions

522cb38


          feat: update interfaces

3dc123e


          test: update integration tests

ed39f02


          test: update unit tests

88eaddf


          feat: add typehash constants

495fde5

0xShaito marked this pull request as draft

October 24, 2024 07:01

linear bot commented Oct 24, 2024

OPO-672 Prophet-modules access control

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/dispute/BondEscalationModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/dispute/BondEscalationModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/dispute/BondEscalationModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/dispute/BondEscalationModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/resolution/BondEscalationResolutionModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/resolution/ERC20ResolutionModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/resolution/ERC20ResolutionModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/resolution/PrivateERC20ResolutionModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/resolution/PrivateERC20ResolutionModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/response/BondedResponseModule.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/test/mocks/MockArbitrator.sol Outdated Show resolved Hide resolved

0xShaito reviewed

View reviewed changes

solidity/contracts/modules/dispute/RootVerificationModule.sol Outdated Show resolved Hide resolved

0xShaito previously requested changes

View reviewed changes

Member

0xShaito left a comment

Great draft. Some small comments and we should have it ready pretty soon

xorsal added 10 commits

October 24, 2024 06:11


          feat: run linter

42cb077


          feat: add AccessControllerModule

73688ac


          feat: pass params to hasAccess modifier

f8e7113


          feat: update typehashes

b3731d3


          feat: releaseUnutilizedResponse does not require access control

5796f29


          feat: update releaseUnutilizedResponse calls

1ebcfc9


          feat: add _defaultAccessControl to AccessControllerModule

5398e63


          feat: remove accessControl param from unnecesary functions

f0b55fc


          test: use access control in corresponding functions

463bfd6


          docs: add access control param to natspec

08fe1ca

xorsal added 6 commits

November 4, 2024 10:20


          test: resolveDispute now uses access control

ff81b35


          feat: resolveDispute in MockAtomicArbitrator

f0b77fb


          chore: fix conflict

cf061e2


          Merge branch 'dev' into feat/access-control

a0d185e


          chore: update prophet-core to canary release

879dc9d


          chore: update yarn.lock

0f5367f

0xJabberwock requested changes

View reviewed changes

solidity/contracts/modules/accessControl/AccessControllerModule.sol Outdated Show resolved Hide resolved

solidity/contracts/modules/resolution/BondEscalationResolutionModule.sol Outdated Show resolved Hide resolved

solidity/contracts/utils/Typehash.sol Outdated Show resolved Hide resolved

solidity/interfaces/IArbitrator.sol Outdated Show resolved Hide resolved

solidity/contracts/modules/dispute/BondEscalationModule.sol Outdated Show resolved Hide resolved

solidity/contracts/modules/dispute/BondEscalationModule.sol Show resolved Hide resolved

0xJabberwock reviewed

View reviewed changes

solidity/contracts/modules/response/BondedResponseModule.sol Outdated Show resolved Hide resolved


          chore: remove commented line, uncomment snippet

71c6b11

0xJabberwock reviewed

View reviewed changes

solidity/contracts/utils/Typehash.sol Outdated Show resolved Hide resolved

linear bot commented Nov 7, 2024

OPT-512 Access control in Modules


          feat: access module (#77)

Co-authored-by: Ashitaka <[email protected]>

gas1cent reviewed

View reviewed changes

solidity/contracts/modules/access/ModuleAccessController.sol Show resolved Hide resolved

gas1cent added 5 commits

November 12, 2024 11:50


          Merge branch 'dev' into feat/access-control

381a9c5


          fix: an extra space

15061db


          refactor: unnecessary AccessControl in IArbitrator

78dd38d


          test: access control in bond escalation module tests

4507e3e


          fix: stack too deep

a57e89d

0xJabberwock reviewed

View reviewed changes

solidity/contracts/modules/access/ModuleAccessController.sol Outdated Show resolved Hide resolved

xorsal and others added 3 commits

November 12, 2024 09:44


          chore: remove addressed todos

b863c5e

by _addressed_ I mean either in this branch or by creating a task to
track it :)


          feat: update prophet-core

ebc91e8


          feat: avoid external calls if access control user is the sender

0977b85

0xJabberwock previously approved these changes

View reviewed changes

report.md Outdated Show resolved Hide resolved


          feat: remove Aderyn report

d5e88d5

gas1cent dismissed 0xJabberwock’s stale review via

d5e88d5

November 12, 2024 15:39

0xJabberwock approved these changes

View reviewed changes

gas1cent dismissed stale reviews from ashitakah and 0xShaito

November 12, 2024 15:43

Stale review

gas1cent merged commit 822962a into dev

3 checks passed

gas1cent deleted the feat/access-control branch

November 12, 2024 15:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet