Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: access control #74

Merged
merged 52 commits into from
Nov 12, 2024
Merged

feat: access control #74

Show file tree
Hide file tree
Changes from 51 commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
522cb38
feat: use access control in all the necessary functions
xorsal Oct 23, 2024
3dc123e
feat: update interfaces
xorsal Oct 23, 2024
ed39f02
test: update integration tests
xorsal Oct 23, 2024
88eaddf
test: update unit tests
xorsal Oct 23, 2024
495fde5
feat: add typehash constants
xorsal Oct 23, 2024
42cb077
feat: run linter
xorsal Oct 24, 2024
73688ac
feat: add AccessControllerModule
xorsal Oct 24, 2024
f8e7113
feat: pass params to hasAccess modifier
xorsal Oct 24, 2024
b3731d3
feat: update typehashes
xorsal Oct 24, 2024
5796f29
feat: releaseUnutilizedResponse does not require access control
xorsal Oct 24, 2024
1ebcfc9
feat: update releaseUnutilizedResponse calls
xorsal Oct 24, 2024
5398e63
feat: add _defaultAccessControl to AccessControllerModule
xorsal Oct 25, 2024
f0b55fc
feat: remove accessControl param from unnecesary functions
xorsal Oct 25, 2024
463bfd6
test: use access control in corresponding functions
xorsal Oct 25, 2024
08fe1ca
docs: add access control param to natspec
xorsal Oct 25, 2024
2b28b57
docs: add natspec for _defaultAccessControl
xorsal Oct 25, 2024
a37968c
docs: add missing natspec for onlyAuthorizedCaller modifier
xorsal Oct 25, 2024
7606748
test: replace mockAC for actual access control
xorsal Oct 30, 2024
384e297
test: use pranked caller in _createAccessControl
xorsal Oct 30, 2024
7c76a8c
feat: use access control in finalize and escalate
xorsal Oct 30, 2024
cb76d9a
chore: remove unused import
xorsal Oct 30, 2024
21cd67e
feat: revealVote is now external
xorsal Oct 30, 2024
137d27e
test: add access control unit test for BondEscalationModule
xorsal Oct 30, 2024
124764a
feat: add unit for access controlled function
xorsal Oct 30, 2024
dbadc59
chore: remove comment
xorsal Oct 30, 2024
eae4ea1
feat: replace usage of msg.sender, instead use accessControl.user
xorsal Oct 31, 2024
618cc36
refactor: rework local variables to avoid stack to deep error
xorsal Oct 31, 2024
28f44e9
chore: lint
xorsal Oct 31, 2024
5f875e4
chore: run linter
xorsal Oct 31, 2024
ea1d17f
feat: declare local variable instead of using access control
xorsal Nov 1, 2024
d526ff9
feat: update circuit resolve module
xorsal Nov 2, 2024
b99f8c1
feat: add another defaultAccessControl fn
xorsal Nov 4, 2024
5fa2a04
docs: review the _isModule check
xorsal Nov 4, 2024
f65effd
test: add vm.skip(false) in a few tests to revisit them later
xorsal Nov 4, 2024
cb2a558
feat: update calldata for memory
xorsal Nov 4, 2024
ff81b35
test: resolveDispute now uses access control
xorsal Nov 4, 2024
f0b77fb
feat: resolveDispute in MockAtomicArbitrator
xorsal Nov 4, 2024
cf061e2
chore: fix conflict
xorsal Nov 4, 2024
a0d185e
Merge branch 'dev' into feat/access-control
xorsal Nov 4, 2024
879dc9d
chore: update prophet-core to canary release
xorsal Nov 4, 2024
0f5367f
chore: update yarn.lock
xorsal Nov 4, 2024
71c6b11
chore: remove commented line, uncomment snippet
xorsal Nov 5, 2024
0541655
feat: access module (#77)
xorsal Nov 10, 2024
381a9c5
Merge branch 'dev' into feat/access-control
gas1cent Nov 12, 2024
15061db
fix: an extra space
gas1cent Nov 12, 2024
78dd38d
refactor: unnecessary `AccessControl` in `IArbitrator`
gas1cent Nov 12, 2024
4507e3e
test: access control in bond escalation module tests
gas1cent Nov 12, 2024
a57e89d
fix: stack too deep
gas1cent Nov 12, 2024
b863c5e
chore: remove addressed todos
xorsal Nov 12, 2024
ebc91e8
feat: update prophet-core
gas1cent Nov 12, 2024
0977b85
feat: avoid external calls if access control user is the sender
gas1cent Nov 12, 2024
d5e88d5
feat: remove Aderyn report
gas1cent Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"package.json": "sort-package-json"
},
"dependencies": {
"@defi-wonderland/prophet-core": "0.0.0-4d28a0ec",
"@defi-wonderland/prophet-core": "0.0.0-0e46031c",
"@openzeppelin/contracts": "4.9.5",
"solmate": "https://github.com/transmissions11/solmate.git#bfc9c25865a274a7827fea5abf6e4fb64fc64e6c"
},
Expand Down
Loading
Loading