Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm-4879 fix for dom text reinterpretation codeql warning #1129

Merged

Conversation

PhilipDeFraties
Copy link
Collaborator

JIRA issue link

https://agile6.atlassian.net/browse/DM-4879

Description - what does this code do?

update metrics page js to sanitize query parameter used to generate url

Testing done - how did you test it/steps on how can another person can test it

On the metrics page for an innovation verify the duration can be updated from "the last 30 days" to "all time"

Screenshots, Gifs, Videos from application (if applicable)

Link to mock-ups/mock ups (image file if you have it) (if applicable)

Acceptance criteria

  • [ ]

Definition of done

  • Unit tests written (if applicable)
  • e2e/accessibility tests written (if applicable)
  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating JIRA issue
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@camillevilla camillevilla force-pushed the dm-4879-fix-dom-text-reinterpret-codeql-warning branch from c38265c to 4b74f76 Compare November 28, 2024 02:56
@PhilipDeFraties PhilipDeFraties merged commit be3736f into master Dec 2, 2024
3 of 4 checks passed
@PhilipDeFraties PhilipDeFraties deleted the dm-4879-fix-dom-text-reinterpret-codeql-warning branch December 2, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants