Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm-4879 fix for dom text reinterpretation codeql warning #1129

Merged
merged 2 commits into from
Dec 2, 2024
Merged

dm-4879 fix for dom text reinterpretation codeql warning #1129

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
604bee6
update metrics page js to sanitize query parameter in metrics page URL
PhilipDeFraties Nov 19, 2024
4b74f76
remove debugger
PhilipDeFraties Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/assets/javascripts/metrics_page.es6
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ $(document).ready(function(){
var pos1 = curUrl.lastIndexOf("?duration");
curUrl = curUrl.substring(0, pos1);
}
let duration = $( "#metrics_duration" ).val();
let duration = encodeURIComponent($("#metrics_duration").val());
let newUrl = `${curUrl}?duration=${duration}`;
window.location.href = newUrl;
});
Expand Down
Loading