Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTILS-143 Upgrade phonenumbers #2302

Merged
merged 2 commits into from
Feb 10, 2025
Merged

UTILS-143 Upgrade phonenumbers #2302

merged 2 commits into from
Feb 10, 2025

Conversation

kalbfled
Copy link
Member

@kalbfled kalbfled commented Feb 10, 2025

Description

Use notification-utils v2.3.3, which upgrades the Python "phonenumbers" package.

issue UTILS 143

How Has This Been Tested?

Unit and regression tests pass.

Checklist

  • I have assigned myself to this PR
  • PR has an appropriate title: #9999 - What the thing does
  • PR has a detailed description, including links to specific documentation
  • I have added the appropriate labels to the PR.
  • I did not remove any parts of the template, such as checkboxes even if they are not used
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to any documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works. Testing guidelines
  • I have ensured the latest main is merged into my branch and all checks are green prior to review
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • The ticket was moved into the DEV test column when I began testing this change

@kalbfled kalbfled marked this pull request as ready for review February 10, 2025 17:44
@kalbfled kalbfled requested a review from a team as a code owner February 10, 2025 17:44
@EvanParish EvanParish merged commit 4304038 into main Feb 10, 2025
5 checks passed
@EvanParish EvanParish deleted the UTILS-143-phonenumbers branch February 10, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants