-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dsl: Overhaul custom fd weights #1644
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1644 +/- ##
===========================================
- Coverage 88.88% 70.28% -18.61%
===========================================
Files 210 162 -48
Lines 33634 21267 -12367
Branches 4391 3493 -898
===========================================
- Hits 29896 14947 -14949
- Misses 3245 5720 +2475
- Partials 493 600 +107
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking really really nice :)
if self.ndims == 1: | ||
_fd_order = fd_order or self._fd_order | ||
_side = side or self._side | ||
new_x0 = {self.dims[0]: x0} if x0 is not None else self.x0 | ||
return self._new_from_self(fd_order=_fd_order, side=_side, x0=new_x0) | ||
new_coeffs = coeffs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
coeffs or self._coeffs
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to check - something wasn't working last night so wrote it in this way for now but quite a few things in there need checking and fixing still.
First thought: drop and burn release Second thought: provide a mini (mini) tutorial explaining how to transition from old to new |
RIght what I had in mind. The it'll be trivial to extend it to allowing For legacy, not completely sure yes to be discussed. |
Sounds good to me. We could add a new tutorial in the |
Yeah, indeed. Will implement that functionality. It's just some minor editing here and there. Re. legacy support, we could for the time being add a decorator to |
dd36e5f
to
e428923
Compare
Done in #2434 closing (easier than rebase that old one) |
Work in progress. TBC.
Aside from the actual implementation, we'll also need to discuss legacy support at some stage.