Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#80 GUI prototype #349

Merged
merged 12 commits into from
Jun 13, 2024
Merged

#80 GUI prototype #349

merged 12 commits into from
Jun 13, 2024

Conversation

slskiba
Copy link
Contributor

@slskiba slskiba commented May 23, 2024

Closes #80
Shows a welcome message in the window.
Display the cli project's version in the window title as poc of module dependency.

@CLAassistant
Copy link

CLAassistant commented May 23, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba thanks for this PR. You really have quickly jump started into the project and already implemented a working solution for the story 👍
As always I am picky and give you lots of review comments for improvement.
Also I am aware that you marked this PR as draft so it is WIP and maybe some of my points are already on your todo list...
I hope my comments help you to continue and improve.

gui/pom.xml Outdated Show resolved Hide resolved
gui/pom.xml Outdated Show resolved Hide resolved
gui/pom.xml Show resolved Hide resolved
gui/pom.xml Outdated Show resolved Hide resolved
gui/pom.xml Outdated Show resolved Hide resolved
gui/src/main/java/com/devonfw/ide/gui/App.java Outdated Show resolved Hide resolved
gui/src/main/java/com/devonfw/ide/gui/App.java Outdated Show resolved Hide resolved
gui/src/main/java/com/devonfw/ide/gui/App.java Outdated Show resolved Hide resolved
gui/src/test/java/com/devonfw/ide/gui/AppBaseTest.java Outdated Show resolved Hide resolved
gui/pom.xml Outdated Show resolved Hide resolved
@slskiba slskiba marked this pull request as ready for review May 28, 2024 07:09
@coveralls
Copy link
Collaborator

coveralls commented May 28, 2024

Pull Request Test Coverage Report for Build 9496934290

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 59.806%

Totals Coverage Status
Change from base Build 9481759920: 0.002%
Covered Lines: 4679
Relevant Lines: 7536

💛 - Coveralls

gui/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba thanks for your rework. Looks nice now.
I added the java.version to the top-level POM. Could you remove it from the cli/pom.xml since it is redundant otherwise (could not do that easily in the browser).

gui/pom.xml Outdated Show resolved Hide resolved
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@slskiba thanks for perfectly addressing all my review comments.
Now ready for merge.

@hohwille hohwille merged commit 6713fca into devonfw:main Jun 13, 2024
3 checks passed
@hohwille hohwille added this to the release:2024.06.001 milestone Jun 13, 2024
@hohwille hohwille added the reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Marks PRs that have been presented in the sprint-review meeting or that do not need to be presented.
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Create a first prototype of a IDEasy GUI with JavaFx
4 participants