refactor: common out node listing and K8sResourceList into K8sResourceList #2216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esourceList BREAKING CHANGES: appliedColumns entry in local storage
…ctor/node-details-list
Elessar1802
requested review from
vikramdevtron and
vivek-devtron
as code owners
AbhishekA1509
requested changes
Nov 20, 2024
src/components/ResourceBrowser/ResourceList/NodeActionsMenu.tsx
Outdated
Show resolved
Hide resolved
src/components/ResourceBrowser/ResourceList/K8SResourceList.tsx
Outdated
Show resolved
Hide resolved
src/components/ResourceBrowser/ResourceList/K8SResourceList.tsx
Outdated
Show resolved
Hide resolved
src/components/ResourceBrowser/ResourceList/K8SResourceList.tsx
Outdated
Show resolved
Hide resolved
…dashboard into fix/node-details-list
…dashboard into fix/node-details-list
AbhishekA1509
previously approved these changes
Nov 21, 2024
fix: add error icon for errors column & colors in status column; replace column selector with select picker
…dashboard into refactor/node-details-list
…ctor/node-details-list
|
vivek-devtron
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of having node listing handled through NodeDetailsList.tsx with this PR, node listing will be handled inside K8sResourceList.tsx. Additionally added constants wherever appropriate and did code cleaning.
Though there is a breaking change with
appliedColumnsfield in local storage. It is not that impactful.Fixes # (issue)
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: