[WIP]: PR for viewing diff

.eslintignore

@@ -66,16 +66,13 @@ src/components/ClusterNodes/ClusterEvents.tsx
 src/components/ClusterNodes/ClusterManifest.tsx
 src/components/ClusterNodes/ClusterNodeEmptyStates.tsx
 src/components/ClusterNodes/ClusterOverview.tsx
-src/components/ClusterNodes/ColumnSelector.tsx
 src/components/ClusterNodes/NodeActions/CordonNodeModal.tsx
 src/components/ClusterNodes/NodeActions/DeleteNodeModal.tsx
 src/components/ClusterNodes/NodeActions/DrainNodeModal.tsx
 src/components/ClusterNodes/NodeActions/EditTaintsModal.tsx
 src/components/ClusterNodes/NodeActions/NodeActionsMenu.tsx
 src/components/ClusterNodes/NodeActions/validationRules.ts
 src/components/ClusterNodes/NodeDetails.tsx
-src/components/ClusterNodes/NodeDetailsList.tsx
-src/components/ClusterNodes/NodeListSearchFilter.tsx
 src/components/ClusterNodes/__tests__/ClusterManifest.test.tsx
 src/components/ClusterNodes/__tests__/NodeList.test.tsx
 src/components/ClusterNodes/constants.ts

package.json

@@ -4,7 +4,7 @@
     "private": true,
     "homepage": "/dashboard",
     "dependencies": {
-        "@devtron-labs/devtron-fe-common-lib": "1.1.0-patch-1",
+        "@devtron-labs/devtron-fe-common-lib": "1.1.6",
         "@esbuild-plugins/node-globals-polyfill": "0.2.3",
         "@rjsf/core": "^5.13.3",
         "@rjsf/utils": "^5.13.3",
@@ -14,7 +14,6 @@
         "@sentry/tracing": "7.50.0",
         "@tippyjs/react": "4.2.6",
         "@typeform/embed-react": "2.20.0",
-        "@types/marked": "4.0.8",
         "@vitejs/plugin-react": "4.3.1",
         "command-line-parser": "^0.2.10",
         "compute-histogram": "^0.9.11",
@@ -23,7 +22,6 @@
         "fast-json-patch": "^3.1.1",
         "flexsearch": "^0.6.32",
         "jsonpath-plus": "^10.0.0",
-        "marked": "4.3.0",
         "moment": "^2.29.4",
         "monaco-editor": "0.44.0",
         "monaco-yaml": "5.1.1",

src/App.tsx

@@ -337,6 +337,7 @@ export default function App() {
                                     <div id="full-screen-modal" />
                                     <div id="visible-modal" />
                                     <div id="visible-modal-2" />
+                                    <div id="animated-dialog-backdrop" />
                                     {import.meta.env.VITE_NODE_ENV === 'production' &&
                                         window._env_ &&
                                         window._env_.HOTJAR_ENABLED && <Hotjar />}

src/Pages/GlobalConfigurations/Authorization/Shared/components/K8sObjectPermissions/K8sListItemCard.tsx

@@ -30,6 +30,7 @@ import {
     GVKType,
     getK8sResourceList,
     EntityTypes,
+    ApiResourceGroupType,
 } from '@devtron-labs/devtron-fe-common-lib'
 import CreatableSelect from 'react-select/creatable'
 import Tippy from '@tippyjs/react'
@@ -177,13 +178,16 @@ const K8sListItemCard = ({
     const createKindData = (selected, _allKindMapping, _k8SObjectMap = null) => {
         const kind = []
         let selectedGvk: GVKType
+        const isAllNamespaceSelected = k8sPermission.namespace.some((option) => option.value === SELECT_ALL_VALUE)
         if (_k8SObjectMap ?? processedData) {
             if (selected.value === SELECT_ALL_VALUE) {
                 // eslint-disable-next-line no-restricted-syntax
                 for (const value of (_k8SObjectMap ?? processedData).values()) {
                     // eslint-disable-next-line no-loop-func
-                    value?.child.forEach((ele: { gvk: GVKType }) => {
-                        kind.push({ value: ele.gvk.Kind, label: ele.gvk.Kind, gvk: ele.gvk })
+                    value?.child.forEach((ele: ApiResourceGroupType) => {
+                        if (isAllNamespaceSelected || ele.namespaced) {
+                            kind.push({ label: ele.gvk.Kind, value: ele.gvk.Kind, gvk: ele.gvk })
+                        }
                         if (!selectedGvk && ele.gvk.Kind === k8sPermission.kind?.value) {
                             selectedGvk = ele.gvk
                         }
@@ -192,7 +196,7 @@ const K8sListItemCard = ({
             } else {
                 const data = (_k8SObjectMap ?? processedData).get(selected.value === 'k8sempty' ? '' : selected.value)
                 data?.child?.forEach((ele) => {
-                    if (ele.namespaced) {
+                    if (isAllNamespaceSelected || ele.namespaced) {
                         kind.push({ label: ele.gvk.Kind, value: ele.gvk.Kind, gvk: ele.gvk })
                     }
                     if (!selectedGvk && ele.gvk.Kind === k8sPermission.kind?.value) {

src/components/CIPipelineN/ciPipeline.utils.tsx

@@ -172,40 +172,6 @@ export const outputFormatSelectStyle = {
     }),
 }
 
-export const containerImageSelectStyles = {
-    ...baseSelectStyles,
-    control: (base, state) => ({
-        ...base,
-        border: '1px solid var(--N200)',
-        boxShadow: 'none',
-        minHeight: 'auto',
-        borderRadius: '4px',
-        height: '32px',
-        fontSize: '12px',
-        pointerEvents: 'auto',
-        cursor: state.isDisabled ? 'not-allowed' : 'pointer',
-    }),
-    valueContainer: (base, state) => ({
-        ...base,
-        color: 'var(--N900)',
-        background: 'var(--N50) !important',
-        padding: '0px 10px',
-        display: 'flex',
-        height: '30px',
-        borderTopLeftRadius: '4px',
-        borderBottomLeftRadius: '4px',
-        fontSize: '12px',
-        width: '100px',
-        whiteSpace: 'nowrap',
-    }),
-    indicatorsContainer: (base, state) => ({
-        ...base,
-        background: 'var(--N50) !important',
-        borderTopRightRadius: '4px',
-        borderBottomRightRadius: '4px',
-    }),
-}
-
 export const CiPipelineSourceTypeBaseOptions = [
     {
         label: 'Branch Fixed',

src/components/ClusterNodes/ClusterNodeEmptyStates.tsx

@@ -15,7 +15,6 @@
  */
 
 import { GenericFilterEmptyState } from '@devtron-labs/devtron-fe-common-lib'
-import React from 'react'
 
 export default function ClusterNodeEmptyState({
     title,

src/components/ClusterNodes/ClusterOverview.tsx

@@ -24,6 +24,7 @@ import {
     EditableTextArea,
     ResourceKindType,
     getUrlWithSearchParams,
+    showError,
 } from '@devtron-labs/devtron-fe-common-lib'
 import {
     ClusterErrorType,
@@ -89,7 +90,7 @@ const tippyForMetricsApi = () => {
     )
 }
 
-function ClusterOverview({ isSuperAdmin, selectedCluster, addTab }: ClusterOverviewProps) {
+function ClusterOverview({ selectedCluster, addTab }: ClusterOverviewProps) {
     const { clusterId, namespace } = useParams<{
         clusterId: string
         namespace: string
@@ -132,7 +133,7 @@ function ClusterOverview({ isSuperAdmin, selectedCluster, addTab }: ClusterOverv
                 })
             }
         } catch (error) {
-            setErrorCode(error['code'])
+            showError(error)
             throw error
         }
     }
@@ -512,7 +513,6 @@ function ClusterOverview({ isSuperAdmin, selectedCluster, addTab }: ClusterOverv
                     <GenericDescription
                         isClusterTerminal
                         clusterId={clusterId}
-                        isSuperAdmin={isSuperAdmin}
                         descriptionId={descriptionData.descriptionId}
                         initialDescriptionText={descriptionData.descriptionText}
                         initialDescriptionUpdatedBy={descriptionData.descriptionUpdatedBy}

src/components/ClusterNodes/ClusterSelectionList.tsx

@@ -60,7 +60,6 @@ const parseSearchParams = (searchParams: URLSearchParams) => ({
 
 const ClusterSelectionList: React.FC<ClusterSelectionType> = ({
     clusterOptions,
-    isSuperAdmin,
     clusterListLoader,
     initialLoading,
     refreshData,
@@ -190,7 +189,7 @@ const ClusterSelectionList: React.FC<ClusterSelectionType> = ({
                     {/* NOTE: visible-hover plays with display prop; therefore need to set display: flex on a new div */}
                     <div className="cursor dc__visible-hover--child ml-8">
                         <div className="flexbox dc__align-items-center dc__gap-4">
-                            {!!clusterData.nodeCount && !clusterListLoader && isSuperAdmin && (
+                            {!!clusterData.nodeCount && !clusterListLoader && (
                                 <Tooltip alwaysShowTippyOnHover content="View terminal">
                                     <div className="flex">
                                         <TerminalIcon