feat: implement cumulative values in PT engine (DHIS2-5497) #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
edoardo
force-pushed
the
feat/pt-cumulative-values-DHIS2-5497
branch
from
1d1f3f2 to
d4717d9
Compare
edoardo
force-pushed
the
feat/pt-cumulative-values-DHIS2-5497
branch
from
d4717d9 to
23a460a
Compare
edoardo
force-pushed
the
feat/pt-cumulative-values-DHIS2-5497
branch
from
7581c12 to
621d992
Compare
This solves formatting issues, like right alignment, caused by the default type being TEXT.
This is needed for the cumulative values feature, so empty cells can be set to 0 or to the accumulated value.
Needed for the cumulative values feature.
This is to accommodate the accumulated value which might need a wider cell. The cell size is computed based on the rendered value.
Refactored and moved some code around to allow getRaw() to return cumulative values, thus fixing the sorting which uses getRaw() to sort the rows/columns.
edoardo
force-pushed
the
feat/pt-cumulative-values-DHIS2-5497
branch
from
2dbc2aa to
0705358
Compare
janhenrikoverland
approved these changes
Dec 14, 2023
edoardo
changed the title
dhis2-bot
added a commit
that referenced
this pull request
Dec 14, 2023
# [26.2.0](v26.1.8...v26.2.0) (2023-12-14) ### Features * implement cumulative values in PT engine (DHIS2-5497) ([#1567](#1567)) ([2b404b4](2b404b4))
|
🎉 This PR is included in version 26.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-5497
Relates to dhis2/data-visualizer-app#2746
Published in 26.2.0-cumulative-values-alpha.1
Key features
cumulativeValuesoption is checkedDescription
Similarly to the option for other vis types, values in a pivot table can be accumulated horizontally.
This behaviour is controlled by the
cumulativeValuesoption in DV.TODO
Screenshots
Data before accumulating the values horizontally:
Same data with accumulation:
