feat: cumulative values in PT (DHIS2-5497) #2746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://pr-2746--dhis2-data-visualizer.netlify.app |
1 task
Passing run #2584 ↗︎
Details:
Review all test suite changes for PR #2746 ↗︎ |
|||||||||||||||
edoardo
changed the title
19 failed tests on run #2393 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Data dimension > initial state > navigates to the start page |
Output
Screenshots
Video
|
|
options/fontStyles.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Options - Font styles > navigates to the start page and adds a data item |
Output
Screenshots
Video
|
|
options/legend.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| Options - Legend > Applying a legend: Column > navigates to the start page and adds data items |
Output
Screenshots
Video
|
|
open.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| opening a saved AO > navigates to the start page |
Output
Screenshots
Video
|
|
new.cy.js • 1 failed test • e2e-chrome-parallel-2.40
| Test | Artifacts | |
|---|---|---|
| creating a new AO > navigates to the start page |
Output
Screenshots
Video
|
|
The first 5 failed specs are shown, see all 19 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
edoardo
force-pushed
the
feat/pt-cumulative-values-DHIS2-5497
branch
from
48bfa52 to
30368b7
Compare
edoardo
force-pushed
the
feat/pt-cumulative-values-DHIS2-5497
branch
from
9aea213 to
ebee722
Compare
Bumps [tar](https://github.com/npm/node-tar) from 4.4.13 to 4.4.19. - [Release notes](https://github.com/npm/node-tar/releases) - [Changelog](https://github.com/npm/node-tar/blob/main/CHANGELOG.md) - [Commits](isaacs/node-tar@v4.4.13...v4.4.19) --- updated-dependencies: - dependency-name: tar dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* feat: support non-gregorian fixed periods * test: fix test failing due to change in single value behaviour --------- Co-authored-by: Jan Henrik Øverland <[email protected]>
* fix: update cli-app-scripts and analytics deps
There are 4 workflows: verify PR (dhis2-verify-app.yml) -- build, lint, test, e2e-prod verify commit to dev (dhis2-verify-app.yml) -- build, lint, test, e2e-prod, report-failure-to-slack verify commit to master (dhis2-verify-app.yml) -- build, lint, test, e2e-prod, release, report-failure-to-slack nightly (nightly.yml) -- e2e-dev, report-failure In addition: * e2e-prod and e2e-dev are reusable workflows and are called from dhis2-verify-app and nightly. * removed uses: c-hive/gha-yarn-cache@v1 since it is deprecated and setup-node handles that work. * updated action versions and node versions * cypress test version tagging for features and bugs has been added (copied from line-list)
…2236) * fix: do not pass a boolean for icons when saving If the option is not set, and thus its value is the same as the default (false) remove it from the current object to avoid sending a boolean value that the backend does not expect. This was causing any save to return 500. * fix: hide icon from visualization when option is toggled This didn't work before because the icons option was removed from the options object, but when the current object was merged with the new options, it retained the original value. * fix: fetch data element icon and pass it in extraOptions This is needed for SV visualizations when the "Show data item icon" options is checked and an icon is assigned to the dx dimension in the maintenance app. In that case the icon's SVG is fetched from the API and passed to the visualization API in the extraOptions object. The SVG generator embeds the icon in the SVG so it appears on the side of the value.
Move the filtering of disabled options in the plugin, which is needed anyway to have the visualization looking the same also in dashboards.
edoardo
force-pushed
the
feat/pt-cumulative-values-DHIS2-5497
branch
from
4a85a12 to
ef0f79d
Compare
We still need to clone the object, and use it also for the various checks on options.
janhenrikoverland
approved these changes
Dec 14, 2023
janhenrikoverland
changed the title
janhenrikoverland
changed the title
Merged
dhis2-bot
added a commit
that referenced
this pull request
Dec 14, 2023
# [100.4.0](v100.3.1...v100.4.0) (2023-12-14) ### Bug Fixes * **translations:** sync translations from transifex (dev) ([65441f2](65441f2)) * **translations:** sync translations from transifex (dev) ([005be59](005be59)) ### Features * cumulative values in PT (DHIS2-5497) ([#2746](#2746)) ([bff69ab](bff69ab)), closes [#1946](#1946)
|
🎉 This PR is included in version 100.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements DHIS2-5497
Requires dhis2/analytics#1567
Key features
cumulativeValuesoption in PTTotals,Number typeandUse legend for chart colorsoptions whencumulativeValuesis checkedDescription
The
cumulativeValuesoption is already implemented for other vis types.We reuse the same option for PT so we don't need any change in the backend, but it requires some custom behaviours because in PT when
cumulativeValuesis enabled other options don't make sense and should be disabled.Known issues
numberTypeoptions are disabled, they are still applied to the PT table if their values are initialised (checkboxes checked and select with a selection).Screenshots
Data tab in Options modal with
cumulativeValuesunchecked for PT vis type:Data tab in Options modal with
cumulativeValueschecked for PT vis type:Legend tab in Options modal with
cumulativeValueschecked for PT vis type: