Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add endpoint to text plain matchers #1390

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

edoardo
Copy link
Member

@edoardo edoardo commented Nov 19, 2024

Key features

  1. programIndicators/expression/description wants a plain text payload

Description

This is similar to indicators/expression/description.
The same function matches now both URLs as they are both about getting an expression in human readable format.


Checklist

  • Have written Documentation
    • Not needed as this is fully internal
  • Has tests coverage

Copy link
Contributor

@HendrikThePendric HendrikThePendric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also don't think this requires a documentation update since this is fully internal

@edoardo edoardo merged commit bc25458 into master Nov 19, 2024
16 checks passed
@edoardo edoardo deleted the fix/add-endpoint-to-text-matcher branch November 19, 2024 17:12
dhis2-bot added a commit that referenced this pull request Nov 19, 2024
## [3.11.3](v3.11.2...v3.11.3) (2024-11-19)

### Bug Fixes

* add endpoint to text plain matchers ([#1390](#1390)) ([bc25458](bc25458))
@dhis2-bot
Copy link
Contributor

KaiVandivier pushed a commit that referenced this pull request Nov 25, 2024
* add endpoint to text plain matchers ([#1390](#1390)) ([bc25458](bc25458))
dhis2-bot added a commit that referenced this pull request Nov 26, 2024
# [3.11.0-alpha.1](v3.10.4-alpha.1...v3.11.0-alpha.1) (2024-11-26)

### Bug Fixes

* **cacheable-section:** synchronously flush recording state for UI consistency ([04bc604](04bc604))
* add endpoint to text plain matchers ([#1390](#1390)) ([de8fbec](de8fbec))
* expand FetchErrorDetails type ([#1389](#1389)) ([78ad0b3](78ad0b3))
* handle alert returned async by parentAlertsAdd [LIBS-695] ([#1388](#1388)) ([bba9c23](bba9c23))
* **cacheable-section:** stable references to avoid loops [LIBS-642] ([#1385](#1385)) ([31562e9](31562e9))
* update plugin sizing definition ([#1383](#1383)) ([38c09b9](38c09b9))
* **deps:** remove cli-app-scripts peer dep [LIBS-587] ([#1379](#1379)) ([9e22e88](9e22e88))
* **deps:** update cli-app-scripts for package/types race condition ([dee6795](dee6795))

### Features

* fixed dimensions efficiency ([#1386](#1386)) ([b56ad2d](b56ad2d))
* upgrade app-runtime React version to v18 ([#1387](#1387)) ([0e4a3d5](0e4a3d5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants