Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove unnecessary calls to the DB during DataValueSet import [D… #15698

Merged
merged 1 commit into from
Nov 15, 2023

fix: Remove unnecessary calls to the DB during DataValueSet import [D…

cddc7d3
Select commit
Loading
Failed to load commit list.
Merged

fix: Remove unnecessary calls to the DB during DataValueSet import [D… #15698

fix: Remove unnecessary calls to the DB during DataValueSet import [D…
cddc7d3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 15, 2023 in 0s

64.77% (+6.18%) compared to 886690f

View this Pull Request on Codecov

64.77% (+6.18%) compared to 886690f

Details

Codecov Report

Merging #15698 (cddc7d3) into 2.39 (886690f) will increase coverage by 6.18%.
Report is 116 commits behind head on 2.39.
The diff coverage is 66.62%.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.39   #15698      +/-   ##
============================================
+ Coverage     58.58%   64.77%   +6.18%     
- Complexity    25817    28692    +2875     
============================================
  Files          3207     3212       +5     
  Lines        121397   121820     +423     
  Branches      14158    14221      +63     
============================================
+ Hits          71118    78905    +7787     
+ Misses        44340    36427    -7913     
- Partials       5939     6488     +549     
Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rc/main/java/org/hisp/dhis/feedback/ErrorCode.java 100.00% <100.00%> (ø)
...src/main/java/org/hisp/dhis/period/PeriodType.java 85.45% <100.00%> (+1.91%) ⬆️
...rg/hisp/dhis/resourcetable/ResourceTableStore.java 100.00% <ø> (+100.00%) ⬆️
... and 113 more

... and 543 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b77ac0...cddc7d3. Read the comment docs.