Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update default values in Tracker exporters OpenAPI [TECH-1580] #15724

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

enricocolasante
Copy link
Contributor

@enricocolasante enricocolasante commented Nov 16, 2023

  • RequestParams objects in exporters must be public in order to make OpenApi generation work correctly for default values
  • Rename generic RequestParams object to specific ENTITYRequestParams
  • Add explicit default values for relevant parameters

All the Sonar issues are related to deprecated annotations

@enricocolasante enricocolasante requested review from jbee and a team November 16, 2023 12:22
Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #15724 (49a4e5d) into master (534dea4) will decrease coverage by 0.04%.
The diff coverage is 80.70%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #15724      +/-   ##
============================================
- Coverage     66.28%   66.25%   -0.04%     
+ Complexity    31416    31410       -6     
============================================
  Files          3492     3492              
  Lines        130167   130202      +35     
  Branches      15214    15215       +1     
============================================
- Hits          86286    86267      -19     
- Misses        36785    36845      +60     
+ Partials       7096     7090       -6     
Flag Coverage Δ
integration 50.01% <11.69%> (-0.02%) ⬇️
integration-h2 32.30% <42.69%> (-0.05%) ⬇️
unit 30.31% <72.51%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...i/controller/tracker/export/PageRequestParams.java 50.00% <ø> (-50.00%) ⬇️
...port/enrollment/EnrollmentRequestParamsMapper.java 96.00% <100.00%> (+0.34%) ⬆️
.../relationship/RelationshipRequestParamsMapper.java 90.69% <100.00%> (+1.22%) ⬆️
...rackedentity/TrackedEntityRequestParamsMapper.java 98.73% <100.00%> (+0.08%) ⬆️
...export/enrollment/EnrollmentsExportController.java 53.33% <33.33%> (-18.76%) ⬇️
...tracker/export/event/EventRequestParamsMapper.java 92.00% <89.09%> (-0.23%) ⬇️
...rt/relationship/RelationshipsExportController.java 51.16% <40.00%> (-18.84%) ⬇️
...trackedentity/TrackedEntitiesExportController.java 63.09% <50.00%> (-9.41%) ⬇️
...r/tracker/export/event/EventsExportController.java 26.41% <10.00%> (-1.04%) ⬇️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 534dea4...49a4e5d. Read the comment docs.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@enricocolasante enricocolasante enabled auto-merge (squash) November 27, 2023 07:59
Copy link

sonarcloud bot commented Nov 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 23 Code Smells

0.0% 0.0% Coverage
10.6% 10.6% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@enricocolasante enricocolasante merged commit 8a2fd86 into master Nov 27, 2023
16 of 17 checks passed
@enricocolasante enricocolasante deleted the TECH-1580 branch November 27, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants