Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved data integrity execution [DHIS2-16223] (2.40) #15804

Merged
merged 6 commits into from
Nov 30, 2023

Conversation

jbee
Copy link
Contributor

@jbee jbee commented Nov 30, 2023

Manual backport of #15789 by picking entire files from master for anything directly data integrity related.
Changes to job scheduling related files were manually changed the same way there were in master.

@jbee jbee self-assigned this Nov 30, 2023
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@jbee jbee marked this pull request as ready for review November 30, 2023 15:39
Copy link
Contributor

@david-mackessy david-mackessy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a large backport :) Just wondering what is the reasoning behind backporting such a large backport if it's not essential or fixing a bug.

@jbee
Copy link
Contributor Author

jbee commented Nov 30, 2023

It's a large backport :) Just wondering what is the reasoning behind backporting such a large backport if it's not essential or fixing a bug.

We always had the plan to backport the data integrity improvements, see DHIS2-14849. We just never got around to make a PR that worked. The reason is that the users of data integrity checks are mainly on 2.39 so they would not benefit much if we only have it in 2.40+. Also we want feedback on the extended DI checks. Last but not least DI is a fairly independent isle so it has little risk of breaking anything else and it is well tested so backporting is not such a big risk overall.

@jbee jbee merged commit 2c2bd3b into dhis2:2.40 Nov 30, 2023
15 checks passed
jbee added a commit to jbee/dhis2-core that referenced this pull request Dec 4, 2023
…5804)

* feat: improved data integrity execution [DHIS2-16223] (2.40)

* fix: compiles again

* fix: update YAML and schema to master

* fix: job creation in controller

* fix: revert table renames

* fix: test setup
jbee added a commit that referenced this pull request Dec 4, 2023
* feat: improved data integrity execution [DHIS2-16223] (2.40) (#15804)

* feat: improved data integrity execution [DHIS2-16223] (2.40)

* fix: compiles again

* fix: update YAML and schema to master

* fix: job creation in controller

* fix: revert table renames

* fix: test setup

* test: backport of tests

* fix: backport of JSON test models

* fix: exception in test setup

* fix: compile error missing constants

* fix: removed moved test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants