-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improved data integrity execution [DHIS2-16223] (2.40) #15804
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs 0.0% Coverage The version of Java (11.0.21) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a large backport :) Just wondering what is the reasoning behind backporting such a large backport if it's not essential or fixing a bug.
We always had the plan to backport the data integrity improvements, see DHIS2-14849. We just never got around to make a PR that worked. The reason is that the users of data integrity checks are mainly on 2.39 so they would not benefit much if we only have it in 2.40+. Also we want feedback on the extended DI checks. Last but not least DI is a fairly independent isle so it has little risk of breaking anything else and it is well tested so backporting is not such a big risk overall. |
…5804) * feat: improved data integrity execution [DHIS2-16223] (2.40) * fix: compiles again * fix: update YAML and schema to master * fix: job creation in controller * fix: revert table renames * fix: test setup
* feat: improved data integrity execution [DHIS2-16223] (2.40) (#15804) * feat: improved data integrity execution [DHIS2-16223] (2.40) * fix: compiles again * fix: update YAML and schema to master * fix: job creation in controller * fix: revert table renames * fix: test setup * test: backport of tests * fix: backport of JSON test models * fix: exception in test setup * fix: compile error missing constants * fix: removed moved test
Manual backport of #15789 by picking entire files from
master
for anything directly data integrity related.Changes to job scheduling related files were manually changed the same way there were in master.