Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task: Extract common validations to helper class [TECH-1677] #16013

Merged
merged 2 commits into from
Dec 21, 2023

task: Remove unused method declaration [TECH-1677]

a991290
Select commit
Loading
Failed to load commit list.
Merged

task: Extract common validations to helper class [TECH-1677] #16013

task: Remove unused method declaration [TECH-1677]
a991290
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 21, 2023 in 0s

66.39% (-0.01%) compared to 8b644f6

View this Pull Request on Codecov

66.39% (-0.01%) compared to 8b644f6

Details

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b644f6) 66.39% compared to head (a991290) 66.39%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #16013      +/-   ##
============================================
- Coverage     66.39%   66.39%   -0.01%     
+ Complexity    31546    31521      -25     
============================================
  Files          3507     3507              
  Lines        130586   130533      -53     
  Branches      15242    15226      -16     
============================================
- Hits          86703    86663      -40     
+ Misses        36809    36804       -5     
+ Partials       7074     7066       -8     
Files Coverage Δ
...dhis/tracker/export/OperationsParamsValidator.java 89.23% <100.00%> (+22.56%) ⬆️
...er/export/enrollment/DefaultEnrollmentService.java 92.47% <ø> (ø)
...rt/enrollment/EnrollmentOperationParamsMapper.java 94.28% <100.00%> (+5.53%) ⬆️
...ckedentity/TrackedEntityOperationParamsMapper.java 76.11% <100.00%> (-0.53%) ⬇️
...acker/export/event/EventOperationParamsMapper.java 93.22% <90.90%> (-1.64%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8415ecd...a991290. Read the comment docs.