Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AuditType failing enum conversion when get tracked entity audits [DHIS2-15805] [ 2.39 ] #16103

Merged
merged 2 commits into from
Jan 9, 2024

fix: make tracked entity audit always insert audit type upper case

08991bc
Select commit
Loading
Failed to load commit list.
Merged

fix: AuditType failing enum conversion when get tracked entity audits [DHIS2-15805] [ 2.39 ] #16103

fix: make tracked entity audit always insert audit type upper case
08991bc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 8, 2024 in 1s

64.96% (+6.37%) compared to 886690f

View this Pull Request on Codecov

64.96% (+6.37%) compared to 886690f

Details

Codecov Report

Attention: 310 lines in your changes are missing coverage. Please review.

Comparison is base (886690f) 58.58% compared to head (08991bc) 64.96%.
Report is 149 commits behind head on 2.39.

Additional details and impacted files
@@             Coverage Diff              @@
##               2.39   #16103      +/-   ##
============================================
+ Coverage     58.58%   64.96%   +6.37%     
- Complexity    25817    28829    +3012     
============================================
  Files          3207     3216       +9     
  Lines        121397   122137     +740     
  Branches      14158    14254      +96     
============================================
+ Hits          71118    79341    +8223     
+ Misses        44340    36270    -8070     
- Partials       5939     6526     +587     
Files Coverage Δ
...main/java/org/hisp/dhis/appmanager/AppManager.java 100.00% <ø> (ø)
...src/main/java/org/hisp/dhis/category/Category.java 65.21% <100.00%> (ø)
.../src/main/java/org/hisp/dhis/common/AuditType.java 100.00% <100.00%> (+10.00%) ⬆️
...ava/org/hisp/dhis/common/BaseAnalyticalObject.java 70.95% <100.00%> (+5.81%) ⬆️
...a/org/hisp/dhis/common/BaseIdentifiableObject.java 80.20% <100.00%> (+1.37%) ⬆️
...s-api/src/main/java/org/hisp/dhis/common/Grid.java 0.00% <ø> (ø)
.../src/main/java/org/hisp/dhis/common/QueryItem.java 68.66% <100.00%> (ø)
...isp/dhis/dataapproval/DataApprovalPermissions.java 91.66% <ø> (+22.43%) ⬆️
...rg/hisp/dhis/dataintegrity/DataIntegrityCheck.java 100.00% <100.00%> (ø)
...isp/dhis/dataintegrity/DataIntegrityCheckType.java 100.00% <100.00%> (+100.00%) ⬆️
... and 109 more

... and 586 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e89dc7...08991bc. Read the comment docs.