Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add paging query param in tracker exporter favor of skipPaging TECH-1678 #16196

Merged
merged 1 commit into from
Jan 18, 2024
Merged

feat: add paging query param in tracker exporter favor of skipPaging TECH-1678 #16196

merged 1 commit into from
Jan 18, 2024

Conversation

teleivo
Copy link
Contributor

@teleivo teleivo commented Jan 17, 2024 •
edited
Loading

to align with metadata and other endpoints

  • paging=false or skipPaging=true will disable paging
  • validate new and old param cannot contradict each other i.e. paging=skipPaging is not allowed
  • make sure we still return paginated results by default

@teleivo teleivo changed the title feat: Add paging query param in tracker exporter favor of skipPaging TECH-1678 feat: add paging query param in tracker exporter favor of skipPaging TECH-1678 Jan 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
0.0% Coverage on New Code
26.2% Duplication on New Code

See analysis details on SonarCloud

@teleivo teleivo requested review from enricocolasante and a team January 17, 2024 12:53
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 17, 2024
View reviewed changes
...-api/src/test/java/org/hisp/dhis/webapi/controller/tracker/export/PageRequestParamsTest.java Dismissed Show dismissed Hide dismissed
...src/test/java/org/hisp/dhis/webapi/controller/tracker/export/RequestParamsValidatorTest.java Dismissed Show dismissed Hide dismissed
.../java/org/hisp/dhis/webapi/controller/tracker/export/enrollment/EnrollmentRequestParams.java Dismissed Show dismissed Hide dismissed
.../java/org/hisp/dhis/webapi/controller/tracker/export/enrollment/EnrollmentRequestParams.java Dismissed Show dismissed Hide dismissed
...i/src/main/java/org/hisp/dhis/webapi/controller/tracker/export/event/EventRequestParams.java Dismissed Show dismissed Hide dismissed
...org/hisp/dhis/webapi/controller/tracker/export/trackedentity/TrackedEntityRequestParams.java Dismissed Show dismissed Hide dismissed
...-web-api/src/main/java/org/hisp/dhis/webapi/controller/tracker/export/PageRequestParams.java Dismissed Show dismissed Hide dismissed
...-web-api/src/main/java/org/hisp/dhis/webapi/controller/tracker/export/PageRequestParams.java Dismissed Show dismissed Hide dismissed
...api/src/main/java/org/hisp/dhis/webapi/controller/tracker/export/RequestParamsValidator.java Dismissed Show dismissed Hide dismissed
...api/src/main/java/org/hisp/dhis/webapi/controller/tracker/export/RequestParamsValidator.java Dismissed Show dismissed Hide dismissed
@enricocolasante enricocolasante requested a review from a team January 17, 2024 14:15
@teleivo teleivo merged commit 0b2fe0d into master Jan 18, 2024
15 checks passed
@teleivo teleivo deleted the TECH-1678 branch January 18, 2024 08:01
This was referenced Jan 18, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaCambi77 lucaCambi77 lucaCambi77 approved these changes

@enricocolasante enricocolasante enricocolasante approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@teleivo @enricocolasante @lucaCambi77