-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submission 456, di Lenardo et al. #35
Conversation
Co-authored-by: Isabella di Lenardo <[email protected]> Co-authored-by: Rémi Petitpierre <[email protected]> Co-authored-by: Lucas Rappo <[email protected]> Co-authored-by: Paul Guhennec <[email protected]> Co-authored-by: Carlo Musso <[email protected]> Co-authored-by: Nicolas Mermoud-Ghraichy <[email protected]>
WalkthroughThe recent changes introduce a structured manuscript project utilizing Quarto, focusing on the evolution of digital methodologies in historical data analysis. Key files include a configuration file for document formatting, a comprehensive index presenting significant themes in data processing, and a references bibliography that supports academic discourse in the field. Together, these updates enhance the usability, presentation, and scholarly foundation of the research project. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Outside diff range, codebase verification and nitpick comments (3)
submissions/456/index.qmd (3)
37-37
: Use a consistent date format.The date format
07-24-2024
could be ambiguous. Consider using a more universally recognized format like2024-07-24
.- date: 07-24-2024 + date: 2024-07-24
48-55
: Lausanne and Venice Census Datasets section is informative.The discussion on maintaining links to original sources and transparency is well-articulated.
Consider clarifying the sentence structure for better readability in the following part:
- This means that datasets can be corrected and refined, particularly when normalizing entity names such as places or people. + Datasets can be corrected and refined, especially when normalizing entity names like places or people.
75-97
: Project examples and technological impacts section is well-structured.The examples and discussions on technological impacts are clear and informative.
Consider rephrasing for clarity:
- The historical information is particularly rich, including the composition of the household, children, place names, servants, housemates, as well as the occupations, municipalities of origin, and dates of birth of all persons mentioned. + The historical information is rich, detailing household composition, children, place names, servants, housemates, occupations, municipalities of origin, and dates of birth for all mentioned persons.
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (4)
submissions/456/images/fig1.png
is excluded by!**/*.png
submissions/456/images/fig2.png
is excluded by!**/*.png
submissions/456/images/fig3.jpg
is excluded by!**/*.jpg
submissions/456/images/fig4.png
is excluded by!**/*.png
Files selected for processing (3)
- submissions/456/_quarto.yml (1 hunks)
- submissions/456/index.qmd (1 hunks)
- submissions/456/references.bib (1 hunks)
Files skipped from review due to trivial changes (2)
- submissions/456/_quarto.yml
- submissions/456/references.bib
Additional comments not posted (2)
submissions/456/index.qmd (2)
41-46
: Introduction section is well-written.The Introduction provides a clear and comprehensive overview of the digital approaches to historical data.
59-73
: Section on computational techniques and data validation is comprehensive.The discussion on data extraction, validation, and computational techniques is thorough and well-presented.
Pull request
Proposed changes
Co-authored-by: Isabella di Lenardo [email protected]
Co-authored-by: Rémi Petitpierre [email protected]
Co-authored-by: Lucas Rappo [email protected]
Co-authored-by: Paul Guhennec [email protected]
Co-authored-by: Carlo Musso [email protected]
Co-authored-by: Nicolas Mermoud-Ghraichy [email protected]
Types of changes
Checklist
Co-authored-by: Name <[email protected]>
.Summary by CodeRabbit
New Features
Documentation