2031: Refactor getDate method #2512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ztefanie
requested review from
steffenkleinle,
sarahsporck,
f1sh1918 and
LeandraH
as code owners
steffenkleinle
approved these changes
Oct 10, 2023
LeandraH
reviewed
Oct 10, 2023
Thanks for testing again, fixed it. |
LeandraH
approved these changes
Oct 10, 2023
|
Nice! Tested in emulated iOS and Firefox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
The getDate method has duplicate code in web and native. I moved the shared logic of choosing the right icon to the api-client. Only selecting the platform specific icons stays in web and native.